Re: PedUnit API commit

[leslie . polzer]

Hello Michael,

On Wed, Jul 06, 2005 at 10:43:16AM -0500, Michael Reed wrote:
> > Please also note that -0 is not valid because sectors start to count from 0.
> 
> What, no one's compliment math?  :)
Sorry ;)


> When doing a mkpart on a freshly labeled disk, I'd sure like to see it
> suggest a starting location for the partition, i.e., first available valid 
> value
> for the current unit.  I don't know where the partition table ends and
> the first available sector lies for all the partition types.
Okay.


> Some (0,-1) test case failures.

> The last two could likely be
> resolved by offering a suggestion for starting sector.
Yes, this is a known issue. I think I'm going to look into it,
but definitely not prior to next week, as I am very low on
time at the moment.


> (parted) mklabel gpt
> (parted) print
> Disk geometry for /dev/sdx: 0s - 71687371s
> Disk label type: gpt
> Number  Start   End     Size    File system  Name                  Flags
> 
> (parted) unit B
> (parted) mkpart
> Partition type?  [primary]?
> File system type?  [ext2]?
> Start? 0
> End? -1
> Error: The location -1 is outside of the device /dev/sdx.
Does this only happen with gpt labels?


> Using units GB, mkpart works but wastes quite a bit
> of space at the end of the disk.  Is this really the way you
> want it to work, leaving almost a GB of unused space at the end of
> the disk?  I'd consider changing the semantics of "-1"
> to be "last available sector relative to the starting sector
> regardless of unit in effect".  This means that if you're trying
> to fill a hole in the disk, all you have to do is get the starting
> location correct and -1 will find the end.  Anyway, something to think
> about.
Special semantics for ``-1''?
This introduces an inconsistency. You can always use ``-1s''.


> I'd still like to see resize of a partition with no filesystem.
> (Patch previously submitted to maintainer(s).)
> 
> And, existent is still misspelled in various test scripts.
> (Patch previously submitted to maintainer(s).)
When did you send these?
I don't think I've received anything like that.

Leslie


-- 
PGP-KID: 0x52D70289

pgp5T4g1c8pQL.pgp
Description: PGP signature