Re: [PATCH] fix HDIO_GETGEO ioctl for linux

[Harley D. Eades III]

On Thu, 2005-11-17 at 11:59 -0500, Andres Salomon wrote:
> On Thu, 2005-11-17 at 17:53 +0100, Szakacsits Szabolcs wrote:
> > On Thu, 17 Nov 2005, Andres Salomon wrote:
> > > On Thu, 2005-11-17 at 13:03 +0100, Szakacsits Szabolcs wrote:
> > > > On Wen, 16 Nov 2005, Andres Salomon wrote:
> > > > 
> [...]
> > 
> > > > If for some reason its wrong values end up to be used then that could
> > > > explain why people are still corrupting their partition tables.
> > > 
> > > There's a comment in the code that suggests moving to EDD.  However, in
> > > linux, that requires loading edd.ko (which is a module in debian
> > > kernels, and is completely disabled in ubuntu kernels).  
> > 
> > Sooner or later they will catch up, other distros include it already for 
> > a long time. 
> 
> I just talked to BenC, he just enabled it for the next ubuntu release.
> 
> So the question is, if /sys/firmware/edd doesn't exist, do we attempt to
> `modprobe edd` from within libparted?  Or is that something that
> libparted should not be doing?
I don't think libparted should be using modprobe to check/init a module.
We could make edd a prereq for libparted or we could find another way
which doesn't involve the use of a linux kernel module.

Cheers
Harley