[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: ext2 strange layout fixes
From: |
Harley D. Eades III |
Subject: |
Re: ext2 strange layout fixes |
Date: |
Sat, 19 Nov 2005 19:51:32 -0600 |
On Sat, 2005-11-19 at 13:36 +0100, Patrick Leslie Polzer wrote:
> I tried to dive into the cruft of fs_ext2 and fix the "strange layout"
> problem, which turned out to be the inability of the original author's
> code to cope with per-group inode table offsets.
>
> Please test it. Also, any comments (except those regarding whitespace or
> commented-out sections which will be alright at commit time) are
> welcome.
I think your patch looks good, I have not tested it yet. One thing I
don't like is the name "howmany()", this is not a very decriptive name
for a function. I don't think you were the one to create the function,
but is this a libparted function or some other libs function?
Great Job!
Harley