[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Parted says too much "Don't forget..."
From: |
Otavio Salvador |
Subject: |
Re: Parted says too much "Don't forget..." |
Date: |
Mon, 16 Apr 2007 15:10:13 -0300 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.95 (gnu/linux) |
Otavio Salvador <address@hidden> writes:
> "Debarshi 'Rishi' Ray" <address@hidden> writes:
>
>>> More importantly: it needs to be set to zero upon declaration.
>>
>> Global variables need not be set to zero upon declaration. They are
>> set to 0 or NULL (whichever is applicable) by default.
>
> Right but would you change the variable name as suggested by Benno?
> It looks much clear to me.
Doing another review on your patch I think would be better to
initialize it since all other variables are being initialized and it
makes the code easier to read. Please, do that.
--
O T A V I O S A L V A D O R
---------------------------------------------
E-mail: address@hidden UIN: 5906116
GNU/Linux User: 239058 GPG ID: 49A5F855
Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
you the whole house."