[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Improve support for mac partition tables with logical sector
Re: [PATCH] Improve support for mac partition tables with logical sector size != 512
Fri, 17 Dec 2010 20:32:14 +0100
Brian C. Lane wrote:
> From: Peter Jones <address@hidden>
> On mac partition tables which specify a sector size larger than the
> physical sector size, we need to reallocate the buffer after we
> determine the correct sector size.
> This is a normal condition when CD is used with Apple partitions (for
> example, the USB rescue stick for the MacBookAir3,1), and then an image
> (analogous to an .iso image) is created, so also don't raise an exception in
> _disk_analyse_block_size() when we find that.
> Also simplify the code in _disk_analyse_block_size() a bit since there's no
> reason to ever do the byteswapping more than once or convert everything to
> 512-byte multiples since we neither load nor store it that way.
> libparted/labels/mac.c | 44 ++++++++++++++++++++++++++------------------
> 1 files changed, 26 insertions(+), 18 deletions(-)
> diff --git a/libparted/labels/mac.c b/libparted/labels/mac.c
Thanks for passing that along.
Thanks to Peter for writing the patch.
Is there a bugzilla number for that, or a test case?
I presume the existing code is causing some sort of failure.
If so, can you give details, or even outline how to provoke failure?
I'd really like to get enough information that I can reproduce
the failure and write a test case.