[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] libparted: fix shadowing of dm_basename.

From: Fabrice Bauzac
Subject: [PATCH] libparted: fix shadowing of dm_basename.
Date: Sun, 7 Apr 2013 04:38:32 +0200


While trying to build parted on my system (version git 1c659d5cc6830c6f4f26660e9049582afbad3fd3)
I have experienced some issues (dependencies not matched, missing software etc).

One of them was a compilation error while building parted:

make[3]: Entering directory `/home/noon/parted/libparted'
  CC       arch/linux.lo
arch/linux.c: In function '_is_dmraid_device':
arch/linux.c:492:21: error: declaration of 'dm_basename' shadows a global declaration [-Werror=shadow]

Here is how I can reproduce the problem on my system:
[see bootstrap.log]
./configure --prefix=$HOME/.prefix/packages/parted
[see configure.log]
[see make.log]

I have renamed the function's local variables to fix the shadowing of the original variable and now "make" succeeds.
Could you please consider fixing the problem in master?  I have prepared a patch for your convenience [fix-shadowing.diff].


Best regards

Attachment: bootstrap.log
Description: Binary data

Attachment: configure.log
Description: Binary data

Attachment: make.log
Description: Binary data

Attachment: fix-shadowing.diff
Description: Binary data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]