bug-pyconfigure
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-pyconfigure] PyConfigure


From: Brandon Invergo
Subject: Re: [Bug-pyconfigure] PyConfigure
Date: Thu, 07 Mar 2013 00:13:35 +0100
User-agent: Notmuch/0.15 (http://notmuchmail.org) Emacs/24.2.1 (x86_64-unknown-linux-gnu)

I've just pushed a couple of commits adapting your patch. I modified the
suggested structure a bit to fit in more or less with the standard
configure.ac layout recommended by Autoconf.

I need to point out that some fixes were rejected though, because you're
working from the "restructure" branch. As I mentioned before, rather
than manually copying files into your project in the next release, there
will be a script to run that copies over the proper files (as I support
more use-cases, the number of template files increases, making
documenting which files to copy over a chore). Thus, there's some stuff
that will seem weird (different file names, weird escapes) if you just
copy over the files manually. 

The (shamefully uncommented) "pyconf.py" script in that branch should
work fine for the standard distutils use-case, if you want to try it
out. You'll first have to change the DATADIR variable in it, which is
currently hard-coded :) After that, just run the script from within a
Python project's directory.

> What I meant is, that since it should always be available, it should
> not have to be in the autoconf.ac: It could just be included in the m4
> macros by default.

I'll have to think about how to do that. Perhaps a macro like
"PC_INIT([min-version], [max-version])", which handles finding the
interpreter and setting up the virtualenv stuff. It would make writing
the configure.ac file easier, for sure.

> So essentially it’s in there to provide an advanced section for people
> who already know Automake and might want to use it?

Right...or maybe even just to give a hint to the dev that Automake is
also an option.

> I mostly missed some notes on peculiarities of the syntax of m4:
> Comments which help newcomers to the language.
>
> Those are the comments you normally don’t need, since normally most
> contributors will know the language you use.

Agreed, and M4 code looks particularly noodle-y to me, even though I
know the language. So more comments will be good.

re: broken links: I used a boiler-plate GNU HTML template, which
explains these
> http://alpha.gnu.org/gnu/pyconfigure/ ) 
I haven't made any alpha releases (well, 0.1 probably should have gone
there, maybe even 0.2)
> Translationproject breaks 
> (http://translationproject.org/domain/pyconfigure.html). 
I haven't gotten anyone to translate for me yet (no program output to
translate yet)


Cheers,
Brandon




reply via email to

[Prev in Thread] Current Thread [Next in Thread]