[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug-readline] [PATCH] shlib: fix build race condition
From: |
Natanael Copa |
Subject: |
[Bug-readline] [PATCH] shlib: fix build race condition |
Date: |
Fri, 14 Mar 2014 08:45:37 +0000 |
When building both static and shared lib on a multicore build server,
there is a possibility that files in $(topdir)/ are updated after the
vi_mode.so is built.
This will force a rebuild and relink of vi_mode.so and the share lib
during make install phase. If user have bilt the shared lib with:
make SHLIB_LIBS=-lncurses
(to avoid underlinking) the relink during make install will remove the
previously SHLIB_LIBS override.
See this thread for more details:
http://lists.gnu.org/archive/html/bug-readline/2014-03/msg00008.html
The vi_mode.so dependency of topdir was most likely unintentional so
we fix it.
---
shlib/Makefile.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/shlib/Makefile.in b/shlib/Makefile.in
index eb16211..693ee05 100644
--- a/shlib/Makefile.in
+++ b/shlib/Makefile.in
@@ -377,7 +377,7 @@ terminal.so: $(topdir)/rlprivate.h
text.so: $(topdir)/rlprivate.h
undo.so: $(topdir)/rlprivate.h
util.so: $(topdir)/rlprivate.h
-vi_mode.so: $(topdir)/
+vi_mode.so: $(topdir)/rlprivate.h
colors.so: $(topdir)/rlprivate.h
parse-colors.so: $(topdir)/rlprivate.h
--
1.9.0
- [Bug-readline] [PATCH] shlib: fix build race condition,
Natanael Copa <=