[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-readline] [PATCH] readline/search.c: Remove useless parameter '
From: |
Chen Gang |
Subject: |
Re: [Bug-readline] [PATCH] readline/search.c: Remove useless parameter '0' for rl_message() |
Date: |
Mon, 22 Sep 2014 23:41:26 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 09/22/2014 09:53 PM, Joel Brobecker wrote:
>>>> The related warning under Darwin x86_64:
>>>>
>>>> gcc -c -DHAVE_CONFIG_H -I. -I../../binutils-gdb/readline
>>>> -DRL_LIBRARY_VERSION='"6.2"' -g -O2 ../../binutils-gdb/readline/search.c
>>>> ../../binutils-gdb/readline/search.c:213:24: warning: data argument not
>>>> used by format string [-Wformat-extra-args]
>>>> rl_message ("%s", p, 0);
>>>> ~~~~ ^
>>>> 1 warning generated.
>>>>
>>>>
>>>> readline/ChangeLog.gdb:
>>>>
>>>> * search.c (_rl_nsearch_init): Remove useless parameter '0' for
>>>> rl_message().
>>>
>>> Because readline is a separate project from binutils/GDB, we prefer
>>> it if you would first submit the patch to the readline project first
>>> (address@hidden, in Cc: of this email), get it accepted there.
>>
OK, thanks, next I shall cc address@hidden, when send new patch
for readline.
>> This bug was already fixed in bash 4.3.
>
> I see! Sorry about the noise.
At least, what you orginally said is useful to me. :-)
And excuse me, my English is not quite well, I am not quite understand
the meaning: "... taking the lead in telling us ...", could you explain
about it in details?
Thanks.
> For my penance, I pushed the patch in.
> Do we need it for 7.8.1 as well?
>
Thanks.
--
Chen Gang
Open share and attitude like air water and life which God blessed
Re: [Bug-readline] [PATCH] readline/search.c: Remove useless parameter '0' for rl_message(), Jan Kratochvil, 2014/09/22