[REGRESSION] Incorrect libcurses detection in 8.2 (on HP-UX)

[Osipov, Michael (IN IT IN)]

Folks,

while trying to configure and compile 8.2 on HP-UX I have a link error 
with -lncurses although configure tells me:
> checking which library has the termcap functions... using libcurses
> checking for ncurses/termcap.h... no

I tracked the issue down to be caused by 
f7a382fd09319b20ef4435b9b554183b605468c1. The proper 
BASH_CHECK_LIB_TERMCAP in 
readline-8.2/examples/autoconf/BASH_CHECK_LIB_TERMCAP has this fallback:
> else
> TERMCAP_LIB=-lcurses
> TERMCAP_DEP=
> fi

which perfectly works for HP-UX and likely others. Now aclocal.m4 has:
> else
> # we assume ncurses is installed somewhere the linker can find it
> TERMCAP_LIB=-lncurses
> TERMCAP_DEP=
> fi

note that libncurses is handled explicitly a few lines up and does not 
require to be the default. The trivial patch is like before in 8.1: 
https://github.com/sailfishos-mirror/readline/blame/cf3c762ecfff5b2f445647a0f1543693984a5540/aclocal.m4#L1024-L1028

Should I create a patch or can this be fixed right away?

After a local fix, it just works:
> # file ./shlib/libreadline.so.8
> ./shlib/libreadline.so.8:       ELF-32 shared object file - IA64
> # ldd ./shlib/libreadline.so.8
>
> ./shlib/libreadline.so.8:
>         libxcurses.so.1 =>      /usr/lib/hpux32/libxcurses.so.1

note that libcurses links to libxcurses.

Michael