[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug-tar] incremental of nfs directory do full every times.
From: |
Jean-Louis Martineau |
Subject: |
[Bug-tar] incremental of nfs directory do full every times. |
Date: |
Fri, 21 Mar 2008 11:51:41 -0400 |
User-agent: |
Thunderbird 2.0.0.12 (X11/20080226) |
Hi,
Incremental of nfs directory do full every times because device number
change.
Attached patch fix a bug because DIR_IS_NFS return 2 if it is NFS.
The biggest problem is the NFS_FILE_STAT which fail to detect if it is NFS.
I read that the device should not be used for other filesystem, eg.
snapshot of zfs, ...
Instead of trying to detect if the device should be used, why not add an
argument:
--no-check-device
I'm willing to do the patch if you will accept it?
Jean-Louis
--- tar-1.19/src/incremen.c 2007-10-01 17:19:55.000000000 -0400
+++ tar-1.19.new/src/incremen.c 2008-03-19 14:51:37.000000000 -0400
@@ -250,7 +250,7 @@
directories, consider all NFS devices as equal,
relying on the i-node to establish differences. */
- if (! (((DIR_IS_NFS (directory) & nfs)
+ if (! (((DIR_IS_NFS (directory) && nfs)
|| directory->device_number == stat_data->st_dev)
&& directory->inode_number == stat_data->st_ino))
{
- [Bug-tar] incremental of nfs directory do full every times.,
Jean-Louis Martineau <=