[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-tar] [PATCH] fix overflow in code_ns_fraction()
From: |
Kamil Dudka |
Subject: |
Re: [Bug-tar] [PATCH] fix overflow in code_ns_fraction() |
Date: |
Fri, 12 Feb 2010 10:07:42 +0100 |
User-agent: |
KMail/1.9.10 |
On Friday 05 of February 2010 17:54:02 Andreas Dilger wrote:
> I would argue that any nanosecond value >= 10^9 is simply due to
> corruption, and propagating that into the seconds field isn't really
> helping anything. However, I agree that it should also check for ns <
To be frank, I've no real life test-case showing it's helpful.
> It is probably worthwhile to have e2fsck et. al. check for and fix
> such corruption, but there are already filesystems in the wild with
> these bad timestamps and tar shouldn't segfault when backing them up.
My reproducer was based on RHEL-5 implementation of tmpfs and I am not
aware of anything like fsck.tmpfs :-)
Attached is a new version of the patch.
Kamil
tar-ns-v3.patch
Description: Text Data