[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-tar] tar -T option
From: |
Pavel Raiskup |
Subject: |
Re: [Bug-tar] tar -T option |
Date: |
Thu, 15 Aug 2013 12:50:41 +0200 |
User-agent: |
KMail/4.10.5 (Linux/3.10.4-300.fc19.x86_64; KDE/4.10.5; x86_64; ; ) |
Hi Sergey,
> Just treat warnings as warnings :) Or apply the following patch, which
> I have just pushed to the repository.
thanks, I was able to recompile it - but I wanted exactly that ^^^ push
from you. Thanks a lot for your work.
I'm looking at the patch once again. Basically, I like the idea you
implemented. But I'm unable to backport to Fedora such big change without
a risk :(. (Ahm, the release cycle of GNU tar is so long.. and
distributions need non-risky back-patching).
-----
Something from my review: I see at least two problems there.
- there is one uninitialized variable, patch attached
- the semantics of -T option changed in relation to -C option. I am
unable to find any note in changelog that this is expected - so I'm just
not sure. Do you really want that? I know that the -T FILE's content
is handled relatively to "current" directory. Thus it is probably more
consistent to try to find FILE also relatively, but... if I'm thinking
as user, I don't like specifying the files relatively to current cwd.
(I can cooperate on fix if you don't have enough time to look at it)
Pavel
0001-tar-fix-use-of-uninitialized-memory.patch
Description: Text Data
- [Bug-tar] tar -T option, Sergey Poznyakoff, 2013/08/04
- Re: [Bug-tar] tar -T option, Pavel Raiskup, 2013/08/05
- Re: [Bug-tar] tar -T option, Sergey Poznyakoff, 2013/08/05
- Re: [Bug-tar] tar -T option,
Pavel Raiskup <=
- Re: [Bug-tar] tar -T option, Sergey Poznyakoff, 2013/08/15
- Re: [Bug-tar] tar -T option, Pavel Raiskup, 2013/08/15
- Re: [Bug-tar] tar -T option, Christian Wetzel, 2013/08/15
- Re: [Bug-tar] tar -T option, Pavel Raiskup, 2013/08/15
- Re: [Bug-tar] tar -T option, Sergey Poznyakoff, 2013/08/15
- Re: [Bug-tar] tar -T option, Pavel Raiskup, 2013/08/16
- Re: [Bug-tar] tar -T option, Sergey Poznyakoff, 2013/08/16
- Re: [Bug-tar] tar -T option, Pavel Raiskup, 2013/08/16
- Re: [Bug-tar] tar -T option, Sergey Poznyakoff, 2013/08/16
- Re: [Bug-tar] tar -T option, Sergey Poznyakoff, 2013/08/16