|
From: | Myung-Hun KO |
Subject: | Re: [Bug-tar] [PATCH 2/2] tar: set stdin/stdout to binary mode on OS/2 if not console |
Date: | Tue, 18 Nov 2014 14:49:56 +0900 |
That patch doesn't look right to me. First, the "#if MSDOS" and "#if defined(__OS2__)" sections of code have a lot in common, and this common part shouldn't be duplicated.
Second, it really should be using the binary-io module, as I mentioned earlier.
Third and most important, whether a file descriptor should be placed into binary mode ought to be a function of whether binary data is being read or written, not whether the file is a terminal. Not every use of "tar" writes binary data to stdout.
[Prev in Thread] | Current Thread | [Next in Thread] |