|
From: | David Binderman |
Subject: | [Bug-tar] tar-1.31/lib/stdopen.c:63]: (style) Suspicious condition |
Date: | Thu, 3 Jan 2019 09:46:44 +0000 |
Hello there,
tar-1.31/lib/stdopen.c:63]: (style) Suspicious condition (assignment + comparison); Clarify _expression_ with parentheses.
Source code is
if (mode == O_RDONLY
|| (new_fd = open ("/dev/full", mode) != fd))
Maybe better code
if (mode == O_RDONLY
|| ((new_fd = open ("/dev/full", mode)) != fd))
Regards
David Binderman
|
[Prev in Thread] | Current Thread | [Next in Thread] |