[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] makeinfo's DocBook abstract (Was: index output)
From: |
José Fonseca |
Subject: |
[PATCH] makeinfo's DocBook abstract (Was: index output) |
Date: |
Thu, 7 Nov 2002 23:38:11 +0000 |
User-agent: |
Mutt/1.4i |
On Thu, Nov 07, 2002 at 03:16:18PM +0000, Jos? Fonseca wrote:
> BTW, I've already discovered the problem with the docbook output
> reported in
> http://mail.gnu.org/pipermail/bug-texinfo/2002-September/005283.html .
> It seems that the code 'xml_insert_element (BOOKINFO, START);' in
> xml.c:827 is being called inside execute_string, but 'xml_insert_element
> (ABSTRACT, END);' in xml.c:714 is not (I can show you the stack back
> traces of this). By some reason in some texinfo documents (such as the
> autoconf-2.53a manual) the expanded abstract is printed twice causing
> unbalanced BOOKINFO/ABSTRACT tags. I still haven't the time to figure
> out the best way to fix this though.
Ok. This only happens with documents which have '@set copying' before
the first node and then a '@insertcopying' after. The code that opens
the BOOKINFO and ABSTRACT flag assumes that it's being output'ed to the
output file, but within '@set/@end copying' it's not the case. My patch
attached makes it verify that it's not inside 'execute_string' and
actually outputing.
This should have no secondary effect, but it's actually hard to tell -
the worst it could happen (in DocBook only) is regular text being
output'd before a node without being inside the ABSTRACT tag, which may
even be accepted by the DocBook DTD.
The fact is that at this point only 4 out of 37 texinfo generated XML
docbooks (including huge stuff such as glibc and gcc) have bad XML
syntax.
José Fonseca
makeinfo-docbook-abstract.diff
Description: Text document