[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH].infokey feature and signal handling are broken

From: AIDA Shinra
Subject: Re: [PATCH].infokey feature and signal handling are broken
Date: Sun, 26 Jan 2003 01:11:44 +0900
User-agent: Wanderlust/2.10.0 (Venus) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.3 (Unebigoryƍmae) APEL/10.4 MULE XEmacs/21.4 (patch 10) (Military Intelligence) (i386-unknown-freebsd4.7)

>     FreeBSD maintainers made this change:
> Meanwhile, any sort of explanation/documentation of what all these
> changes are doing would be helpful :).  For instance, what bug it's
> fixing ...

After "C-z", window resize and "fg", original info takes window size
as the size before "C-z" and scatters the screen. It means info should
recheck window size after "fg". The first change by FreeBSD maintainers
aimed to fix it but created another bug (C-z fg C-z q). The second
code is (probably) correct way.

The attached patch does more. It aims double signal safety in addition
to "C-z resize fg" fix. Signal handlers block another signal because
most functions don't seem to be reentrant. In fact my patch is no
sufficient because signals might be caught in unsafe context. I think
we should catch signals only in read(tty) and similar waits. But it's
paranoiac so I cared only double signals, which are more likely.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]