Re: makeinfo segfaults with @itemize line with @item on the same line

[Karl Berry]

    I triggered makeinfo from texinfo-4.5 to segfault with the following 
    construct:

    @itemize @bullet @item on the same line that itemize

Here's a patch that tries to circumvent it by checking for @item in the
@itemize argument up front.  I surmise the seg fault was just running
out of stack space from the recursive @item invocation.

Thanks for the report.


*** insertion.c 13 Feb 2003 16:09:38 -0000      1.17
--- insertion.c 24 Feb 2003 14:41:51 -0000      1.19
***************
*** 1,5 ****
  /* insertion.c -- insertions for Texinfo.
!    $Id: insertion.c,v 1.17 2003/02/13 16:09:38 karl Exp $
  
     Copyright (C) 1998, 1999, 2000, 2001, 2002, 2003 Free Software
     Foundation, Inc.
--- 1,5 ----
  /* insertion.c -- insertions for Texinfo.
!    $Id: insertion.c,v 1.19 2003/02/24 14:41:51 karl Exp $
  
     Copyright (C) 1998, 1999, 2000, 2001, 2002, 2003 Free Software
     Foundation, Inc.
***************
*** 130,136 ****
--- 130,149 ----
  get_item_function ()
  {
    char *item_function;
+   char *item_loc;
+   
    get_rest_of_line (0, &item_function);
+ 
+   /* If the document erroneously says
+        @itemize @bullet @item foobar
+      it's nicer to give an error up front than repeat address@hidden expected
+      braces' until we get a segmentation fault.  */
+   item_loc = strstr (item_function, "@item");
+   if (item_loc)
+     {
+       line_error (_("@item not allowed in argument to @itemize"));
+       *item_loc = 0;
+     }
  
    /* If we hit the end of text in get_rest_of_line, backing up
       input pointer will cause the last character of the last line