Crash on empty node

[Peter N Lewis]

I get the following crash on a particular empty note (don't know how 
general it is) at insertion.c:1645 with makeinfo 4.5

Thread 0 Crashed:
 #0   0x90009330 in strncmp
 #1   0x0000b8b0 in cm_item (insertion.c:1645)
 #2   0x000119b0 in read_command (makeinfo.c:1921)
 #3   0x00011d94 in reader_loop (makeinfo.c:2038)
 #4   0x0000437c in handle_include (cmds.c:1356)
 #5   0x000119b0 in read_command (makeinfo.c:1921)
 #6   0x00011d94 in reader_loop (makeinfo.c:2038)
 #7   0x00010f60 in convert_from_loaded_file (makeinfo.c:1589)
 #8   0x0000f88c in main (makeinfo.c:776)
 #9   0x000023a0 in _start (crt.c:267)
 #10  0x00002220 in start

The problem occurs with

strncmp ((char *) output_paragraph
                              + output_paragraph_offset - sizeof (dl_tag) + 1,
                              dl_tag, sizeof (dl_tag) - 1) != 0)

when the output_paragraph_offset is less than (sizeof (dl_tag) - 1). 
The fix is to guard against this case, presumably (going by the 
comment) inserting the <br> in this case.

              if (!itemx_flag
                  && ((output_paragraph_offset < sizeof (dl_tag) + 1)
                     || (strncmp ((char *) output_paragraph
                              + output_paragraph_offset - sizeof (dl_tag) + 1,
                              dl_tag, sizeof (dl_tag) - 1) != 0) ) )

Enjoy,
   Peter.

--
<http://www.interarchy.com/>  <http://download.interarchy.com/>