Re: 4.5: @set before @setfilename is ignored

[Akim Demaille]

 Akim> Hi Karl,

 >> It looks like @set commands (and maybe other commands?) are ignored
 >> before @setfilename.  
 >> 
 >> Everything is ignored before @setfilename.

Actually, there are two issues here, one being that I don't think that
applying @value to an undefined flag is not correct.  I suggest the
following patch:

Index: ChangeLog
from  Akim Demaille  <address@hidden>

        * makeinfo/makeinfo.c (cm_value): Warn for undefined flags.

Index: makeinfo/makeinfo.c
===================================================================
RCS file: /cvsroot/texinfo/texinfo/makeinfo/makeinfo.c,v
retrieving revision 1.25
diff -u -u -u -w -r1.25 makeinfo.c
--- makeinfo/makeinfo.c 20 Apr 2003 23:46:45 -0000 1.25
+++ makeinfo/makeinfo.c 28 Apr 2003 06:34:20 -0000
@@ -3768,7 +3768,10 @@
       if (value)
         execute_string ("%s", value);
       else
+       {
+         warning (_("undefined flag: %s"), name);
         add_word_args (_("{No value for `%s'}"), name);
+       }
 
       free (name);
     }



PS/ Karl, you might want to have a look at whitespace.el by Noah
Friedman, to canonicalize the sources: there are zillions of trailing
spaces in there.

http://www.splode.com/~friedman/software/emacs-lisp/index.html

http://www.splode.com/~friedman/software/emacs-lisp/src/whitespace.el

        Nukes trailing whitespace from the ends of lines, and deletes
        excess newlines from the ends of buffers, every time you
        save. It's mode-sensitive, so for some modes it will ask you
        before doing anything; in some cases it will clean up
        whitespace unconditionally; and in other cases it will never
        do so.

        There is a whitespace.el included with Emacs since 1999, but
        that is not the same as this version. My version predates that
        one, but I declined to have mine bundled with Emacs for vague
        technical reasons.