bug-texinfo
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: texi2dvi: A more pleasant way to compile


From: Akim Demaille
Subject: Re: texi2dvi: A more pleasant way to compile
Date: Fri, 10 Jun 2005 09:16:06 +0200
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux)

>>> "Karl" == Karl Berry <address@hidden> writes:

 > Hi Akim,

 >     I would like to checkin now
 > I checked it in, with text-only changes to the --help msg and ChangeLog.

Thanks!

 > (To make it clearer that the default is unchanged. :)

Actually, I'm not sure the default-default should be specified.  In my
case, since of course TEXI2DVI_BUILD_MODE=tidy, it results in:

| Build modes:
|   --build=MODE  specify the treatment of auxialiary files [tidy]
                                                            ******
| 
| [...]
|   `local'  compile in the current directory, leaving all the auxiliary
|              files around.  This is the default.
                              ********************


 >     - README
 > README?  The --help documentation you wrote looks pretty good.

I meant the *.t2d/README file to document the subdirectories.

 >     - --mostlyclean
 > As I said, I want to call it something else, since I think it should be
 > called at make clean, not mostlyclean.

I meant the feature, I'm not religious wrt the name :)

 >     - *.t2d should probably be named (located?) after OUTPUT.dvi instead
 >       of INPUT.tex

 > Yes, I think you're right.  Both named and located.

OK.

 >       -t, --tidy    same as --build=tidy

 > -t is already taken, but I see that was only in the doc, not the code.
 > I removed it from the doc.

Thanks!

 > Thanks again for persevering with all this.

My pleasure :)


There's a bug in this version: -o is not respected.

Index: ChangeLog
from  Akim Demaille  <address@hidden>

        * util/texi2dvi (run_tex): Updating the output is also needed when
        -o is used, not just when $tidy.

Index: util/texi2dvi
===================================================================
RCS file: /cvsroot/texinfo/texinfo/util/texi2dvi,v
retrieving revision 1.53
diff -u -u -r1.53 texi2dvi
--- util/texi2dvi 9 Jun 2005 22:07:13 -0000 1.53
+++ util/texi2dvi 10 Jun 2005 07:15:01 -0000
@@ -349,12 +349,13 @@
 
   verbose "Running $cmd ..."
   if eval "$cmd" >&5; then
-    if $tidy; then
-      # Update the actual output.
-      case $oname in
-       '') dest=$orig_pwd;;
-        *) dest=$oname;;
-      esac
+    # Update the actual output.
+    case $tidy:$oname in
+      true:)  dest=$orig_pwd;;
+      false:) dest=;;
+      *:*)    dest=$oname;;
+    esac
+    if test -n "$dest"; then
       verbose "Copying $oformat file from `pwd` to $dest"
       cp -p "./$filename_noext.$oformat" "$dest"
     fi






reply via email to

[Prev in Thread] Current Thread [Next in Thread]