Re: Bug#355367: debuild: Preserving locale settings can affect build

[Norbert Preining]

Hi Karl!

One more thing I forgot:

On Die, 07 Mär 2006, Karl Berry wrote:
>     but how to expand the 2 letter code to a full setting?
> 
> Well, although I see the manual says a two-letter code, clearly that is
> not completely correct, although I don't recall anyone writing to me
> about it.  If someone wanted to differentiate German German from
> Austrian German, they should be able to use address@hidden de'
> for the first and address@hidden de_AT' for the second.
> 
> So the answer is, make a lookup table which translates the two-letter
> codes to their respective "common" value, e.g., fr->fr_FR, de->de_DE, etc.
> 
> Question: is de_DE, fr_FR, etc., really needed for gettext?  If you just
> say "de" to gettext (in some way), doesn't it guess you mean de_DE?

At least on my system it doesn't work:
[~] LC_ALL=de gettext texinfo Next ; echo
Next
address@hidden:
[~] LC_ALL=de_AT gettext texinfo Next ; echo
nächstes


But my locale.gen file does not contain de flat.

> Just for my own information, are there in fact any differences with
> German German and Austrian German with respect to these few words?  Take

No, I wouldn't say. I would also say that most languages variants do NOT
disagree on these simple words. 

> a look at txi-de.tex and see if any of it would be different in Austria.
> (The list of words there should also give some clues about other places
> to apply __.)

No, all ok here.

> One would think.  I was scared off by Bruno's telling me that the
> "simple" way to switch languages (which you implemented) was wrong
> somehow.  I find gettext quite "magical", overall.

Hmm, ok, maybe it is wrong, but it works ;-) Hopefully.

> Now, some comments on the patch:
> 
>     +char interface_language[21] = "C";
>     ...
> +       strncpy(interface_language, optarg, 20);
> 
> 21?  No.  Make it a char * and use xstrdup on optarg.

DOne. I added the initial
        interface_language = xstrdup("C");
to the beginning of the main.c in makeinfo, couldn't find another place.

>     +char *getdocumenttext (const char *msgid)
>     ...
>     +  safedlocale = setlocale(LC_ALL,NULL);
> 
> Not that it is important, and not that I'm complaining, but GNU style
> is to format code like this:
> 
> char *
> getdocumenttext (...)

done.

>   safedlocale = setlocale (LC_ALL, NULL);  /* with spaces */
> 
> Also, "safed" should be "save_" :).

done.

> Thanks very much for all this.  Actual progress, after lo these many
> years :).

New patch with more fixed occurrences of __ soon. I have Japanese course
now.

Best wishes

Norbert

-------------------------------------------------------------------------------
Dr. Norbert Preining <preining AT logic DOT at>             Università di Siena
gpg DSA: 0x09C5B094      fp: 14DF 2E6C 0307 BE6D AD76  A9C0 D2BF 4AA3 09C5 B094
-------------------------------------------------------------------------------
BOSCASTLE
A huge pyramid of tin cans placed just inside the entrance to a
supermarket.
                        --- Douglas Adams, The Meaning of Liff