bug-texinfo
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] infokeys, scrolling behavior etc.


From: Sergey Poznyakoff
Subject: Re: [PATCH] infokeys, scrolling behavior etc.
Date: Thu, 19 Jul 2007 13:06:34 +0300

Benno Schulenberg <address@hidden> ha escrit:

> Ehm... not entirely.  For example: `info msgmerge`, </>, <Enter>, 
> <Tab>, <Enter>...  Kermess!

It is not entirely connected with the scrolling patch: the
info_copy_reference function failed to copy line_number, which
triggered this behavior. It was not visisble when
cursor-movement-scrolls=Off, probably because the garbage contained in
the resulting line_number field formed an integer larger that the window
size, due to which info_next_line function returned without doing
anything.

Here is the fix:

Index: info/info-utils.c
===================================================================
RCS file: /cvsroot/texinfo/texinfo/info/info-utils.c,v
retrieving revision 1.7
diff -p -u -r1.7 info-utils.c
--- info/info-utils.c   1 Jul 2007 21:20:30 -0000       1.7
+++ info/info-utils.c   19 Jul 2007 10:01:01 -0000
@@ -289,7 +289,8 @@ info_references_internal (char *label, S
       strncpy (entry->label, refdef, offset - 1);
       entry->label[offset - 1] = '\0';
       canonicalize_whitespace (entry->label);
-
+      entry->line_number = 0;
+      
       refdef += offset;
       entry->start = start;
       entry->end = refdef - binding->buffer;
@@ -395,6 +396,7 @@ info_copy_reference (REFERENCE *src)
   dest->nodename = src->nodename ? xstrdup (src->nodename) : NULL;
   dest->start = src->start;
   dest->end = src->end;
+  dest->line_number = 0;
   
   return dest;
 }

Regards,
Sergey
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]