[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] small memory leak in makeinfo.c:convert_from_file

From: Stephen Compall
Subject: Re: [patch] small memory leak in makeinfo.c:convert_from_file
Date: Fri, 21 Sep 2007 20:25:54 -0500

On Fri, 2007-09-21 at 18:02 -0500, Karl Berry wrote:
> I agree there's a memory leak, but I worry about this free.
> input_filename is set in many places to many things, including
> references in structures, etc.  It seems like the free could invalidate
> them.  Am I missing something?  I didn't actually try to find a test
> case, just eyeballed the sources ...

The free only happens after a successful find_and_load.  find_and_load
gets what it puts in input_filename from get_file_info_in_path, which
always returns a freshly malloced str or NULL.  find_and_load doesn't
save any part of this block anywhere else but input_filename.

> The truth is, I have not tried very hard to eliminate such small memory
> leaks.  In fact, I've added plenty.  Life is just too short ... makes no
> real difference in a short-lived process like makeinfo that I can see.

Certainly.  I was just reading source and it bugged me.

;;; Stephen Compall ** http://scompall.nocandysw.com/blog **
"Peta" is Greek for fifth; a petabyte is 10 to the fifth power, as
well as fifth in line after kilo, mega, giga, and tera.
  -- Lee Gomes, performing every Wednesday in his tech column
     "Portals" on page B1 of The Wall Street Journal

Attachment: signature.asc
Description: This is a digitally signed message part

reply via email to

[Prev in Thread] Current Thread [Next in Thread]