Re: Regression in 4.12: install-info inserts spurious whitespace

[Ulrich Mueller]

>>>>> On Tue, 13 May 2008, Karl Berry wrote:

> Thanks again for the report.  I installed this patch in CVS and it
> passes all (now) 52 tests.

> (The basic idea is to use ". " instead of just "." to separate the
> node name from the description, so we can handle config.status.
> Sigh.)

With the patched 4.12 I get a segmentation fault because of "strdup"
being called with a null pointer argument (which doesn't happen with
vanilla 4.12). I include some debugging info below.

Ulrich


gdb> run --dir-file=dir /usr/share/info/autoconf.info.gz

Program received signal SIGSEGV, Segmentation fault.
[...]
gdb> where
#0  0x77f913b3 in strlen () from /lib/libc.so.6
#1  0x77f910f5 in strdup () from /lib/libc.so.6
#2  0x0804b448 in split_entry (entry=0x9511dc8 "* autoupdate: 
(autoconf)autoupdate Invocation.\n", ' ' <repeats 32 times>, "Automatic update 
of `configure.ac'\n", name=0x7fe95e34, name_len=0x7fe95e2c, 
description=0x7fe95e30, description_len=0x7fe95e28) at install-info.c:1466
#3  0x0804b6ef in reformat_new_entries (entries=0x9511ec0, 
calign_cli=0xffffffff, align_cli=0xffffffff, maxwidth_cli=0xffffffff) at 
install-info.c:1550
#4  0x0804ce4b in main (argc=0x3, argv=0x7fe96064) at install-info.c:2266
gdb> up 2
#2  0x0804b448 in split_entry (entry=0x944cdc8 "* autoupdate: 
(autoconf)autoupdate Invocation.\n", ' ' <repeats 32 times>, "Automatic update 
of `configure.ac'\n", name=0x7f90e8a4, name_len=0x7f90e89c, 
description=0x7f90e8a0, description_len=0x7f90e898) at install-info.c:1466
1466          *name = strdup (ptr);
gdb> p ptr
$1 = 0x0
gdb> list
1461      if (!ptr)
1462        {
1463          size_t length = strlen (entry);
1464          if (length == 0)
1465            return;
1466          *name = strdup (ptr);
1467          *name_len = length + 1;
1468          return;
1469        }
1470
gdb>