bug-texinfo
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Regression in 4.12: install-info inserts spurious whitespace


From: Karl Berry
Subject: Re: Regression in 4.12: install-info inserts spurious whitespace
Date: Sun, 18 May 2008 12:43:06 -0500

    I don't know if I really understand the code, but shouldn't '\n' be
    included in the following condition?

    +  while (ptr && ptr[1] != ' ' && ptr[1] != '\t') {
    +    ptr = strchr (ptr + 1, '.');
    +  }

Yes.  Doing that had caused other problems in the past, but it seems ok
now, according to the (now) 53 tests :).

Thanks,
karl

--- install-info.c.~1.12.~      2008-05-12 11:50:59.000000000 -0700
+++ install-info.c      2008-05-18 09:52:38.000000000 -0700
@@ -1453,5 +1454,6 @@ split_entry (char *entry, char **name, s
      that's a period and space -- our heuristic to handle item names like
-     "config.status", and node names like "config.status Invocation".  */
+     "config.status", and node names like "config.status Invocation".
+     Also accept period-tab and period-newline.  */
   char *ptr = strchr (entry, '.');
-  while (ptr && ptr[1] != ' ' && ptr[1] != '\t') {
+  while (ptr && ptr[1] != ' ' && ptr[1] != '\t' && ptr[1] != '\n') {
     ptr = strchr (ptr + 1, '.');




reply via email to

[Prev in Thread] Current Thread [Next in Thread]