[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[patch] Use "($cmd)" in place of "$(cmd)" in gendocs.sh
From: |
Ben Pfaff |
Subject: |
[patch] Use "($cmd)" in place of "$(cmd)" in gendocs.sh |
Date: |
Sat, 13 Feb 2010 20:59:56 -0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
I noticed this bug by inspection. That is, I didn't actually try
to format DocBook either with or without it, so it's possible
that for some weird reason it makes sense to use command
substitution here. But I doubt it.
(I seem to recall signing copyright papers for Texinfo a number
of years ago when I was tentatively planning to do some work on
it that I never got around to doing.)
2010-02-13 Ben Pfaff <address@hidden>
* util/gendocs.sh: Use "($cmd)" in place of "$(cmd)" where
command substitution is not desired.
Index: util/gendocs.sh
===================================================================
RCS file: /sources/texinfo/texinfo/util/gendocs.sh,v
retrieving revision 1.32
diff -u -p -r1.32 gendocs.sh
--- util/gendocs.sh 3 Jan 2010 14:31:17 -0000 1.32
+++ util/gendocs.sh 14 Feb 2010 04:54:15 -0000
@@ -2,7 +2,7 @@
# gendocs.sh -- generate a GNU manual in many formats. This script is
# mentioned in maintain.texi. See the help message below for usage details.
-scriptversion=2010-01-02.16
+scriptversion=2010-02-13.20
# Copyright 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010
# Free Software Foundation, Inc.
@@ -274,7 +279,7 @@ texi_tgz_size=`calcsize $outdir/$PACKAGE
if test -n "$docbook"; then
cmd="$SETLANG $MAKEINFO -o - --docbook \"$srcfile\" >
${srcdir}/$PACKAGE-db.xml"
- echo "Generating docbook XML... $(cmd)"
+ echo "Generating docbook XML... ($cmd)"
eval "$cmd"
docbook_xml_size=`calcsize $PACKAGE-db.xml`
gzip -f -9 -c $PACKAGE-db.xml >$outdir/$PACKAGE-db.xml.gz
@@ -302,7 +307,7 @@ if test -n "$docbook"; then
mv $PACKAGE-db.txt $outdir/
cmd="${DOCBOOK2PS} ${outdir}/$PACKAGE-db.xml"
- echo "Generating docbook PS... $(cmd)"
+ echo "Generating docbook PS... ($cmd)"
eval "$cmd"
gzip -f -9 -c $PACKAGE-db.ps >$outdir/$PACKAGE-db.ps.gz
docbook_ps_gz_size=`calcsize $outdir/$PACKAGE-db.ps.gz`
--
On Perl: "It's as if H.P. Lovecraft, returned from the dead and speaking by
seance to Larry Wall, designed a language both elegant and terrifying for his
Elder Things to write programs in, and forgot that the Shoggoths didn't turn
out quite so well in the long run." --Matt Olson
- [patch] Use "($cmd)" in place of "$(cmd)" in gendocs.sh,
Ben Pfaff <=