[bug #32255] info crashes if # of rows is very small

[Hilmar Preusse]

URL:
  <http://savannah.gnu.org/bugs/?32255>

                 Summary: info crashes if # of rows is very small
                 Project: texinfo - GNU documentation system
            Submitted by: hpreusse
            Submitted on: Wed 26 Jan 2011 03:59:07 PM GMT
                Category: info
                 Release: 4.13a
                Priority: 5 - Normal
                Severity: 3 - Normal
              Item Group: bug
                 Privacy: Public
             Open/Closed: Open
             Assigned to: None
         Discussion Lock: Any
                  Status: None

    _______________________________________________________

Details:

We got a bug report down here in the DBTS: http://bugs.debian.org/611151

<snip>
This bug is easy to reproduce.  Simply run "info" in a terminal, then resize
the terminal to have a height smaller than 6.  The info program immediately
exits with a segmentation fault.

The problem is that window.c:window_line_of_point() can return a negative
index. A simple fix is to sanity check the output (patch
attached).

That patch will prevent segmentation faults, but there is still something
wrong with the arithmetic, probably in window_new_screen_size() which is a
mess.  Shrinking and enlarging the buffer repeatedly leaves a gap, but that's
the subject for another bug.
<snip>

The submitter provided a patch, which can be found in the bug report (not
tested by me).

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?32255>