[bug #32975] install-info: `(null) --help'

[Sergey Poznyakoff]

Follow-up Comment #4, bug #32975 (project texinfo):

I agree with (1) and (2).

As to (3), gettext is of course not able to handle this.
It is the responsibility of xgettext.  And it would have reported an error and
refused to create the mo file, if fatal() had been declared as pass-c-format,
i.e. had the --flag=fatal:1:pass-c-format option been given in
XGETTEXT_OPTIONS in po/Makevars.  This is the standard method to prevent such
bugs, so it qualifies as a bug in our Makevars.   I'll fix this, but there
remains a minor point: fatal() is not exactly printf-like, it always takes a
second arguments and expects at most one %s specifier in its format string. 
The same holds true for error().  This makes both functions error-prone: it
would suffice to supply a format string with any non-%s printf specifier to
make them print garbage in best case and coredump in the worst one.

I would rather redeclare both as (const char *,...).  WDYT?



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?32975>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/