bug-texinfo
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix a crash in stand-alone Info due to bad indexing of a string


From: Sergey Poznyakoff
Subject: Re: Fix a crash in stand-alone Info due to bad indexing of a string
Date: Fri, 22 Mar 2013 01:44:08 +0300

Karl Berry <address@hidden> ha escrit:

> It's not a feature, it's a bug.

Actually, I'm not quite sure it is. The capitalization is intended to
highlight the part of string that is matched. The source states it
plainly in a comment on line 457:

    /* If we had a partial match, indicate to the user which part of the
       string matched. */

Arguably, there are better ways to highlight the text than upcasing it
(by using the terminal capabilities, for instance), but that's the way
the things stood so far, so perhaps we should restore it.

If, on the other hand, we agree that there's no need in this, I
can just remove that code which will both remove the cause of the
coredump and simplify the code greatly.

Opinions?

Regards,
Sergey



reply via email to

[Prev in Thread] Current Thread [Next in Thread]