[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Minor build fixes
From: |
Gavin Smith |
Subject: |
Re: Minor build fixes |
Date: |
Mon, 6 Oct 2014 13:49:44 +0100 |
>> >> --- info/termdep.h (revision 5852)
>> >> +++ info/termdep.h (working copy)
>> >> @@ -49,7 +49,7 @@
>> >> # endif /* !HAVE_TERMIO_H */
>> >> #endif /* !HAVE_TERMIOS_H */
>> >>
>> >> -#ifdef GWINSZ_IN_SYS_IOCTL
>> >> +#ifndef __MINGW32__
>> >> # include <sys/ioctl.h>
>> >> #endif
>> >>
>> >
>> > I see the same thing (conditional on __MINGW32__) is done when
>> > including sys/ioctl.h in info/ioctl.h and info/man.h. It looks like
>> > GWINSZ_IN_SYS_IOCTL is set by the AC_HEADER_TIOCGWINSZ macro in
>> > configure.ac. However, your patch is probably what we want because
>> > we're not just including <sys/ioctl.h> to get TIOCGWINSZ (although I
>> > don't understand why you would want the definition of TIOCGWINSZ and
>> > /not/ have the definition of ioctl, so maybe I'm missing something?)
>>
>> I don't understand that either. In any case, I think it's clear that we
>> need to
>> include <sys/ioctl.h> on most systems, regardless of the value of
>> GWINSZ_IN_SYS_IOCTL.
>
> These considerations omit the MSDOS case, which also doesn't want
> sys/ioctl.h. Not sure about other Windows compilers, or whether they
> are still supported.
I am wondering if "sys/ioctl.h" should be added to AC_CHECK_HEADERS in
configure.ac and then the include made conditional on
"HAVE_SYS_IOCTL_H".
Re: Minor build fixes, Gavin Smith, 2014/10/06