Re: makeinfo bug - smallquotation command

[Patrice Dumas]

On Fri, Nov 14, 2014 at 01:25:30PM +0000, Gavin Smith wrote:
> I think the following fixes it. Could Patrice or Karl confirm?

Indeed, it looks ok.  I will check the tests and commit on your behalf
if it is ok with you.

> 
> * tp/Texinfo/Convert/Plaintext.pm (_convert) <@quotation with
> @author>: Check if @smallquotation was used as well.
> 
> Index: tp/Texinfo/Convert/Plaintext.pm
> ===================================================================
> --- tp/Texinfo/Convert/Plaintext.pm     (revision 5923)
> +++ tp/Texinfo/Convert/Plaintext.pm     (working copy)
> @@ -3142,7 +3142,9 @@
>            $result .= $self->_convert($tree);
>          }
>        }
> -    } elsif ($root->{'cmdname'} eq 'quotation' and $root->{'extra'}
> +    } elsif (($root->{'cmdname'} eq 'quotation'
> +               or ($root->{'cmdname'} eq 'smallquotation'))
> +            and $root->{'extra'}
>               and $root->{'extra'}->{'authors'}) {
>        foreach my $author (@{$root->{'extra'}->{'authors'}}) {
>          $result .= $self->_convert(
> 
> On Fri, Nov 14, 2014 at 11:43 AM, Mahlon <address@hidden> wrote:
> > 14 Nov. 2014
> >
> > Sorry to be a pest, but I found a few more problems.
> > I'll send them individually for ease in tracking.
> >
> > RE: '@smallquotation' command and its '@author' sub-command
> >
> > Version: makeinfo 5.2 (built from source on Fedora 20 x86_64)
> >
> > Bug:
> >
> > The '@author', if specified within the '@smallquotation' block,
> > is not displayed in the output.
> >
> > '@author' works as specified in the '@quotation' block, so the
> > '@smallquotation' just needs to be made symmetrical.
> >
> > Sample Source:
> >
> > @smallquotation
> >
> > Heroes are seldom born. Instead, they spring to life when circumstances
> > demand
> >
> > it and recede into the background when the crisis has passed.
> >
> > @author anon
> >
> > @end smallquotation
> >
> >
> > Cheers!
> >
> > Mahlon
> >
> >
> > --
> >
> > Software Sam - software and tools for GNU/Linux
> >
> > Mahlon Smith,
> > The Software Samurai
> > On the Web: http://www.SoftwareSam.us/
>