bug-texinfo
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 'raggedright' command in HTML output


From: Patrice Dumas
Subject: Re: 'raggedright' command in HTML output
Date: Wed, 19 Nov 2014 22:29:45 +0100
User-agent: Mutt/1.5.20 (2009-12-10)

On Wed, Nov 19, 2014 at 07:05:58PM +0000, Gavin Smith wrote:
> On Mon, Nov 17, 2014 at 3:42 AM, Mahlon <address@hidden> wrote:
> > According to the documentation, the @raggedright command does not apply to
> > info and HTML output, obviously because the command applies only to output
> > formats that can produce 'justified' text. The 'info' output correctly
> > processes the paragraph as ordinary paragraph text. Note however, that for
> > some reason, the HTML converter produces no output for the paragraph.
> 
> The patch below appears to fix it, although I don't understand
> everything that is going on and if there are other changes that need
> to be made as well. At line 7289 this will make the condition be true
> because it will have been initialized at line 4609 (revision 5923).
> 
> Index: tp/Texinfo/Convert/HTML.pm
> ===================================================================
> --- tp/Texinfo/Convert/HTML.pm  (revision 5923)
> +++ tp/Texinfo/Convert/HTML.pm  (working copy)
> @@ -2482,6 +2482,7 @@
>    return $content;
>  }
> 
> +$default_commands_conversion{'raggedright'} = \&_convert_command_noop;
>  $default_commands_conversion{'flushleft'} = \&_convert_command_noop;
>  $default_commands_conversion{'flushright'} = \&_convert_command_noop;
>  $default_commands_conversion{'group'} = \&_convert_command_noop;

That looks good.  The only thing that come to my mind is that, sometime
it may be better to use categories of @-commands defined in
Texinfo/Common.pm, but in that case, the raggedright is in the
"align_command" hash, but center is there too, so I think your patch is
best.

In the HTML converter, all the @-commands are associated with function
references to make them configurable.

Also, please check that the test work correctly before commiting, and if
not regenerate them.

-- 
Pat



reply via email to

[Prev in Thread] Current Thread [Next in Thread]