[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: @ref in @multitable broken in Info output if split across lines

From: Patrice Dumas
Subject: Re: @ref in @multitable broken in Info output if split across lines
Date: Wed, 11 Feb 2015 13:48:17 +0100
User-agent: Mutt/1.5.20 (2009-12-10)

On Wed, Feb 11, 2015 at 12:34:02PM +0000, Gavin Smith wrote:
> > And not forget to pop it when leaving a footnote (l. 866) (and also
> > probably in l. 3314 though I don't really remember what it corresponds
> > to).
> l.3314 refers to the 'indent_menu_descriptions' function. I haven't
> popped it there because it didn't call 'push_top_formatter', nor
> pushed to 'document_context' itself.

You are right, I misread the code, all those are pushed in the function.

> On Mon, Feb 9, 2015 at 1:04 AM, Patrice Dumas <address@hidden> wrote:
> > There are potential issues with things like
> >   $in_multitable = 1;
> > if there are some nestings.  I don't remember if nested @*ref are
> > allowed, but if it is the case the $in_multitable variable will
> > be set to 0 upon getting out of the @*ref within.
> This was a local variable so I expected it to be reset in other calls
> (in this case, recursive calls). I used it to make clear that the
> "entering whitespace protection" and "exiting whitespace protection"
> code would always be executed as a pair, rather than repeating the
> condition which would leave someone reading the code wondering if the
> condition had changed in the meantime.

Ok, I thought they weren't in the same block.  Your approach is
perfectly valid.  I have no further comment on the proposed patch, it
looks good.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]