bug-texinfo
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: possible of include of incorrect config.h file


From: Patrice Dumas
Subject: Re: possible of include of incorrect config.h file
Date: Wed, 19 Aug 2015 15:53:27 +0200
User-agent: Mutt/1.5.20 (2009-12-10)

On Wed, Aug 19, 2015 at 02:05:46PM +0100, Gavin Smith wrote:
> On 19 August 2015 at 10:53, Patrice Dumas <address@hidden> wrote:
> > The C files in XSParagraph still compile when there is no config.h,
> > because they use the config.h in some perl include directory.  I think
> > that it is a potential source of confusion.  I would propose using a
> > specific name instead of config.h, for example xsparagraph_acconfig.h.
> >
> > If it is ok, I can do a patch.
> 
> Why wouldn't the config.h exist?

It should exist in general, but if for some reason it does not, there
will be no easy way to understand that a change in behaviour or an error
happens because the config.h file included is the perl one and not the
one done by configure.

It is not for the common cases, but an extra security, and I only raise
that issue because the config.h file from perl is in a directory
searched for by the preprocessor, if not I wouldn't propose that.  Also
I raise that issue because it happened to me, when doing the standalone
module, it compiled while it shouldn't have.

It could in particular be interesting for people debugging something and
doing the compilation themselves instead of using the Makefile.  Or if
there is some problem in the Makefile and config.h is not remade when
there is another config.h on the preprocessor path.

-- 
Pat



reply via email to

[Prev in Thread] Current Thread [Next in Thread]