Re: [bug #43122] texi2dvi does not compile enough times to get toc

[Gavin Smith]

On 2 September 2015 at 07:45, Vincent Belaïche
<address@hidden> wrote:
> Salut Gavin,
>
> My answers inserted below...
>
>> I see no need for a command-line flag.
>>
>
> It allows you to test whether the \openout is still working. Otherwise
> you may wind up with dead parts of code that are never (can't be ever)
> tested. But anyway, I did not see any test bench for texi2dvi...

The environment variable could still be used.
>
>
>> "pushd" and "popd" are bash extensions, use cd instead.
>>
>
> Done... MSYS sh did not bark at that.

Did you see the attachment to my email? I already made this change.
Apologies if I could have made this clearer - it would have saved you
some effort. I'll have a look at your latest patch, anyway. If I'd
known you'd be willing do this work, I'd have waited to see what you
did. Could you have a look at the latest version I emailed - it was
supposed to be able to cope with an index called "fl".

> Sorry, four spaces were the default with Emacs. I have added some Emacs
> cookie at the end of the texi2dvi file to configure indent consistently
> with the existing code. I hope that no one minds about that, otherwise
> it is not a problem to do the same configuration via an sh-mode hook
> function in my init file.
>
> I also noticed that you have one space between function names and `()',
> I fixed that for new functions.

Okay, thanks.

>> Space after \openout in regexp. Check for single quote after filename.
>> Remove $ anchor from end of regexp. Format for openout lines must
>> differ between web2c and MikTeX.
>
> MikTeX does not have any openout lines, so I wrote the regexp w/o any
> way for testing. Which regexp are you pointing at, that of the check
> function ?

Again, I was referring to the changes that I already had made.


>> We'll also need a ChangeLog entry.
>>
>
> Done, I also added something into the manual for all the environment
> variables influencing texi2dvi (not only the new one).

Thanks for the ChangeLog entry.
>
> Please note that I removed the trailing blanks in the ChangeLog.

You shouldn't have bothered. They aren't causing any problems. I'm not
going to commit this.

>
> For the manual, probably there should be some forward reference from
> node `Format with texi2dvi' to node `Other Customization Variables', as
> the latter is below texi2any.
>
>> Here's the current state. It would benefit from more testing and
>> review. I'l have another look at it in the next couple of days.
>
> I definitely agree that more testing is needed. Some test bench with
> something like
>
> rm -fr test.log
> test1_options=-u no --tidy
> test2_options=--tidy
> test3_options=--tidy
> for test in test1 test2 test3; do
>   if texi2pdf ${${test}_options} $test.texi; then
>     pdftotext $test.pdf
>     if diff -q $test.txt ref/$test.txt; then
>       echo "Failed diff to ref: $test" >> test.log;
>     fi
>   else
>       echo "Failed compilation: $test" >> test.log;
>   fi
> done

Would you, or anybody else, like to get this working? I agree a test
bench would be very helpful.