HAVE_MSVC_INVALID_PARAMETER_HANDLER test unquoted

[Karl Berry]

Gnulib people - Eli Z reported seeing this familiar shell diagnostic
with the current Texinfo configure:

  ./configure: line 22339: test: =: unary operator expected

That line turns out to be:

  if test $HAVE_MSVC_INVALID_PARAMETER_HANDLER = 1; then

And looking at gnulib/m4, indeed that variable is used unquoted in
several places.  I don't know if it's supposed to be guaranteed to be
set, but if so, evidently that guarantee is failing.  Maybe
gl_MSVC_INVAL needs to be changed somehow.

Alternatively, here is a simple diff that quotes the instances that grep
found.  No guarantees from me as to completeness :), and I didn't
increment the serial numbers for the sake of not cluttering the patch.

?

k

diff --git a/m4/close.m4 b/m4/close.m4
index 310f076..a0da1e9 100644
--- a/m4/close.m4
+++ b/m4/close.m4
@@ -8,7 +8,7 @@ AC_DEFUN([gl_FUNC_CLOSE],
 [
   AC_REQUIRE([gl_UNISTD_H_DEFAULTS])
   AC_REQUIRE([gl_MSVC_INVAL])
-  if test $HAVE_MSVC_INVALID_PARAMETER_HANDLER = 1; then
+  if test "$HAVE_MSVC_INVALID_PARAMETER_HANDLER" = 1; then
     REPLACE_CLOSE=1
   fi
   m4_ifdef([gl_PREREQ_SYS_H_WINSOCK2], [
diff --git a/m4/dup.m4 b/m4/dup.m4
index 4fb0d30..6dfa7ca 100644
--- a/m4/dup.m4
+++ b/m4/dup.m4
@@ -8,7 +8,7 @@ AC_DEFUN([gl_FUNC_DUP],
 [
   AC_REQUIRE([gl_UNISTD_H_DEFAULTS])
   AC_REQUIRE([gl_MSVC_INVAL])
-  if test $HAVE_MSVC_INVALID_PARAMETER_HANDLER = 1; then
+  if test "$HAVE_MSVC_INVALID_PARAMETER_HANDLER" = 1; then
     REPLACE_DUP=1
   fi
   dnl Replace dup() for supporting the gnulib-defined fchdir() function,
diff --git a/m4/fdopen.m4 b/m4/fdopen.m4
index 685a1bb..45eea6a 100644
--- a/m4/fdopen.m4
+++ b/m4/fdopen.m4
@@ -9,7 +9,7 @@ AC_DEFUN([gl_FUNC_FDOPEN],
   AC_REQUIRE([gl_STDIO_H_DEFAULTS])
   AC_REQUIRE([AC_CANONICAL_HOST]) dnl for cross-compiles
   AC_REQUIRE([gl_MSVC_INVAL])
-  if test $HAVE_MSVC_INVALID_PARAMETER_HANDLER = 1; then
+  if test "$HAVE_MSVC_INVALID_PARAMETER_HANDLER" = 1; then
     REPLACE_FDOPEN=1
   else
     dnl Test whether fdopen() sets errno when it fails due to a bad fd 
argument.
diff --git a/m4/fstat.m4 b/m4/fstat.m4
index 29f9b81..7295627 100644
--- a/m4/fstat.m4
+++ b/m4/fstat.m4
@@ -9,7 +9,7 @@ AC_DEFUN([gl_FUNC_FSTAT],
   AC_REQUIRE([gl_SYS_STAT_H_DEFAULTS])
 
   AC_REQUIRE([gl_MSVC_INVAL])
-  if test $HAVE_MSVC_INVALID_PARAMETER_HANDLER = 1; then
+  if test "$HAVE_MSVC_INVALID_PARAMETER_HANDLER" = 1; then
     REPLACE_FSTAT=1
   fi
 
diff --git a/m4/raise.m4 b/m4/raise.m4
index 71c1f4c..820687d 100644
--- a/m4/raise.m4
+++ b/m4/raise.m4
@@ -13,7 +13,7 @@ AC_DEFUN([gl_FUNC_RAISE],
   if test $ac_cv_func_raise = no; then
     HAVE_RAISE=0
   else
-    if test $HAVE_MSVC_INVALID_PARAMETER_HANDLER = 1; then
+    if test "$HAVE_MSVC_INVALID_PARAMETER_HANDLER" = 1; then
       REPLACE_RAISE=1
     fi
     m4_ifdef([gl_SIGNALBLOCKING], [
diff --git a/m4/read.m4 b/m4/read.m4
index 5a18c11..632f015 100644
--- a/m4/read.m4
+++ b/m4/read.m4
@@ -8,7 +8,7 @@ AC_DEFUN([gl_FUNC_READ],
 [
   AC_REQUIRE([gl_UNISTD_H_DEFAULTS])
   AC_REQUIRE([gl_MSVC_INVAL])
-  if test $HAVE_MSVC_INVALID_PARAMETER_HANDLER = 1; then
+  if test "$HAVE_MSVC_INVALID_PARAMETER_HANDLER" = 1; then
     REPLACE_READ=1
   fi
   dnl This ifdef is just an optimization, to avoid performing a configure
diff --git a/m4/write.m4 b/m4/write.m4
index d9b93f9..0a345a9 100644
--- a/m4/write.m4
+++ b/m4/write.m4
@@ -8,7 +8,7 @@ AC_DEFUN([gl_FUNC_WRITE],
 [
   AC_REQUIRE([gl_UNISTD_H_DEFAULTS])
   AC_REQUIRE([gl_MSVC_INVAL])
-  if test $HAVE_MSVC_INVALID_PARAMETER_HANDLER = 1; then
+  if test "$HAVE_MSVC_INVALID_PARAMETER_HANDLER" = 1; then
     REPLACE_WRITE=1
   fi
   dnl This ifdef is just an optimization, to avoid performing a configure