[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: info crashes if .infokey contains the "invalid" action
From: |
Gavin Smith |
Subject: |
Re: info crashes if .infokey contains the "invalid" action |
Date: |
Fri, 4 Mar 2016 19:39:39 +0000 |
On 4 March 2016 at 17:08, Ken Brown <address@hidden> wrote:
> This isn't the right fix. It prevents the crash, but it doesn't correctly
> process the "invalid" line in .infokey. I tested with the following
> .infokey:
>
> $ cat .infokey
> #info
> ^a invalid
>
> After startup, ^a still moved to the beginning of the line. I won't try to
> fix this right now, because someone familiar with the code can probably do
> it much faster.
I think I've fixed it now. (SVN revision 7040). Thanks for passing it
on: I expect that it has been broken since before the 6.0 release due
to changes in the code.
Your fix didn't work because of a change to the keymap_bind_keyseq
function where it wouldn't override already bound key sequences. This
enabled a simplification of the code, removing functions
find_function_keyseq and remove_function_keyseq which were used to
remove the key sequence from the map from commands to key sequences
used for the message in the help window.