bug-texinfo
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bug#23985: Emacs 25.0.94: FEATURE ADDITION: Texinfo environment move


From: Eli Zaretskii
Subject: Re: bug#23985: Emacs 25.0.94: FEATURE ADDITION: Texinfo environment movement commands
Date: Thu, 14 Jul 2016 22:19:54 +0300

> From: Robert Weiner <address@hidden>
> Date: Thu, 14 Jul 2016 12:19:46 -0400
> 
> The attached patch adds movement commands for texinfo-mode that move
> between the start and end of single-level environments (things that
> end with an @end line), e.g. @table.

Thanks.  Allow me a few comments.

> + ;;; Texinfo environment, e.g. @table, movement commands
> + ;; Author: Bob Weiner <address@hidden>, Orig-Date: 7/14/2016
> + ;; Copyright (C) 2016  Free Software Foundation, Inc.

We don't put such comments into the code, the log entry and AUTHORS
serve this purpose.

> + (defun texinfo-to-environment-bounds ()
> +   "If within a Texinfo environment with an @end, move point first to its 
> starting line and then to its ending line.

The first line of a doc string should not be wider than 67 characters,
certainly not more than 78, and it should still be a complete sentence
that summarizes what the function does.

> + Do nothing when outside of an environment; this does not handle nested 
> environments."

Other lines should also be broken at character 70.

I think these additions should be also reflected in NEWS.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]