Re: Windows style improvements

[Jason Hood]

On 30/01/2017 0:03, Gavin Smith wrote:
> I've applied this with the following ChangeLog entry:

Some clarifications.

>         (highvideo):
>         (blinkvideo): Use intense background instead of intense
>         foreground.

(highvideo): Invert the normal foreground intensity, instead of
just setting it.
(normvideo): Remove underline attribute.  Use the normal
intensities, instead of just removing them.
(blinkvideo): Invert the normal background intensity, instead of
using highvideo.

>         (textcolor, textbackground): Include bit for underlined text
>         when calling 'textattr'.

(textcolor, textbackground): Preserve underline attribute.

>         (convert_color): Extract 'intensity' bit from argument.
>         (pc_set_fg_color): Include foreground intensity when calling
>         textcolor.
>         (pc_set_bg_color): Include background intensity when calling
>         textcolor.

(convert_color, pc_set_fg_color, pc_set_bg_color): Use the normal
intensities.

>         (pc_initialize_terminal): Initialized the 'normattr' bit on
>         'xref_attr' from outside_info.normattr.  Support underline in
>         INFO_COLORS.  Set 'terminal_end_all_modes_hook' to
>         'pc_default_color' instead of 'pc_end_standout'.

(pc_initialize_terminal): Use the normal background for 'xref_attr',
instead of black.  Support underline in INFO_COLORS.  Really end all
modes, not just standout.

> I do not understand the code so I had trouble writing this.

Sorry; now I know why you're supposed to supply ChangeLog entries.

-- 
Jason.