Is Info browser tilde expansion necessary?

[Gavin Smith]

On 25 January 2017 at 00:22, Hans-Bernhard Bröker <address@hidden> wrote:
> Hello everyone,
>
> since checking the code for possible holes appears to the theme of the
> month...
>
> I had a go with clang's analyzer (on Cygwin) on current SVN source (r7649).
> It found about a dozen possible uninitalized reads, use-after-frees and null
> pointer dereferences, primarily in 'info':
>
> (Reported "dead stores" snipped here)
> Logic error
> Branch condition evaluates to a garbage value           2
> Called function pointer is null (null dereference)      1
> Dereference of null pointer                             6
> Result of operation is garbage or undefined             1
> Unix API (<-- NULL passed to string functions)          2
>
> Memory Error
> Memory leak                                             1
> Use-after-free                                          2
>
> (Reports list attached separately because lines are too long).

Thanks for sending; I'm working through the issues you reported.

With regards to any problems in tilde.c, I'd prefer to resolve this by
deleting the file. I don't think the Info browser needs to convert
tilde characters into the user's home directory. I don't know why this
feature was added in the first place (looking at the ChangeLog, it
looks like it's been there from the start). Tilde expansion is done by
the shell so there's no need for Info to do it as well.