Re: texinfo-6.3.90 pretest

[Eli Zaretskii]

> Cc: address@hidden
> From: Hans-Bernhard Bröker <address@hidden>
> Date: Sat, 29 Apr 2017 21:31:44 +0200
> 
> The build itself fails because of the conflict between xspara.c and 
> gnulib headers:
> 
> make[5]: Entering directory 
> '/home/hbbro/prgbld/w64/txisvn_ASPerl/tp/Texinfo/Convert/XSParagraph'
> /bin/sh ./libtool  --tag=CC   --mode=compile 
> C:/msys64/mingw64/bin/gcc.exe -DHAVE_CONFIG_H -I. 
> -I/c/prg/gnu/texinfo/svn/tp/Texinfo/Convert/XSParagraph 
> -I/c/prg/gnu/texinfo/svn/tp/Texinfo/Convert/XSParagraph 
> -I/c/prg/gnu/texinfo/svn/tp/Texinfo/Convert/XSParagraph/lib -I./lib  -s 
> -O2 -DWIN32 -DWIN64 -DCONSERVATIVE -DPERL_TEXTMODE_SCRIPTS 
> -DUSE_SITECUSTOMIZE -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -fwrapv 
> -fno-strict-aliasing -mms-bitfields -DVERSION=\"0\" -DXS_VERSION=\"1\" 
> "-IC:/Perl64/lib/CORE"  -MT XSParagraph_la-xspara.lo -MD -MP -MF 
> .deps/XSParagraph_la-xspara.Tpo -c -o XSParagraph_la-xspara.lo `test -f 
> 'xspara.c' || echo 
> '/c/prg/gnu/texinfo/svn/tp/Texinfo/Convert/XSParagraph/'`xspara.c
> libtool: compile:  C:/msys64/mingw64/bin/gcc.exe -DHAVE_CONFIG_H -I. 
> -I/c/prg/gnu/texinfo/svn/tp/Texinfo/Convert/XSParagraph 
> -I/c/prg/gnu/texinfo/svn/tp/Texinfo/Convert/XSParagraph 
> -I/c/prg/gnu/texinfo/svn/tp/Texinfo/Convert/XSParagraph/lib -I./lib -s 
> -O2 -DWIN32 -DWIN64 -DCONSERVATIVE -DPERL_TEXTMODE_SCRIPTS 
> -DUSE_SITECUSTOMIZE -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -fwrapv 
> -fno-strict-aliasing -mms-bitfields -DVERSION=\"0\" -DXS_VERSION=\"1\" 
> -IC:/Perl64/lib/CORE -MT XSParagraph_la-xspara.lo -MD -MP -MF 
> .deps/XSParagraph_la-xspara.Tpo -c 
> /c/prg/gnu/texinfo/svn/tp/Texinfo/Convert/XSParagraph/xspara.c 
> -DDLL_EXPORT -DPIC -o .libs/XSParagraph_la-xspara.o
> In file included from C:/Perl64/lib/CORE/perl.h:718:0,
>                   from 
> C:/prg/gnu/texinfo/svn/tp/Texinfo/Convert/XSParagraph/xspara.c:34:
> C:/prg/gnu/texinfo/svn/tp/Texinfo/Convert/XSParagraph/xspara.c:174:1: 
> error: expected declaration specifiers or '...' before numeric constant
>   iswspace (wint_t wc)
>   ^
> C:/prg/gnu/texinfo/svn/tp/Texinfo/Convert/XSParagraph/xspara.c:201:1: 
> error: expected declaration specifiers or '...' before numeric constant
>   iswupper (wint_t wc)
>   ^
> make[5]: *** [Makefile:967: XSParagraph_la-xspara.lo] Error 1
> 
> And another problem further down, in MiscXS:
> 
> make[4]: Entering directory 
> '/home/hbbro/prgbld/w64/txisvn_ASPerl/tp/Texinfo/MiscXS'
> /bin/sh ./libtool  --tag=CC   --mode=compile 
> C:/msys64/mingw64/bin/gcc.exe -DHAVE_CONFIG_H -I. 
> -I/c/prg/gnu/texinfo/svn/tp/Texinfo/MiscXS    -s -O2 -DWIN32 -DWIN64 
> -DCONSERVATIVE -DPERL_TEXTMODE_SCRIPTS -DUSE_SITECUSTOMIZE 
> -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -fwrapv -fno-strict-aliasing 
> -mms-bitfields -DVERSION=\"0\" -DXS_VERSION=\"0\" "-IC:/Perl64/lib/CORE" 
>   -MT MiscXS_la-misc.lo -MD -MP -MF .deps/MiscXS_la-misc.Tpo -c -o 
> MiscXS_la-misc.lo `test -f 'misc.c' || echo 
> '/c/prg/gnu/texinfo/svn/tp/Texinfo/MiscXS/'`misc.c
> libtool: compile:  C:/msys64/mingw64/bin/gcc.exe -DHAVE_CONFIG_H -I. 
> -I/c/prg/gnu/texinfo/svn/tp/Texinfo/MiscXS -s -O2 -DWIN32 -DWIN64 
> -DCONSERVATIVE -DPERL_TEXTMODE_SCRIPTS -DUSE_SITECUSTOMIZE 
> -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -fwrapv -fno-strict-aliasing 
> -mms-bitfields -DVERSION=\"0\" -DXS_VERSION=\"0\" -IC:/Perl64/lib/CORE 
> -MT MiscXS_la-misc.lo -MD -MP -MF .deps/MiscXS_la-misc.Tpo -c 
> /c/prg/gnu/texinfo/svn/tp/Texinfo/MiscXS/misc.c  -DDLL_EXPORT -DPIC -o 
> .libs/MiscXS_la-misc.o
> In file included from C:/prg/gnu/texinfo/svn/tp/Texinfo/MiscXS/misc.c:34:0:
> C:/prg/gnu/texinfo/svn/tp/Texinfo/MiscXS/misc.c: In function 
> 'xs_unicode_text':
> C:/Perl64/lib/CORE/perl.h:166:16: error: 'my_perl' undeclared (first use 
> in this function)
>   #  define aTHX my_perl
>                  ^
> C:/Perl64/lib/CORE/embedvar.h:38:18: note: in expansion of macro 'aTHX'
>   #    define vTHX aTHX
>                    ^~~~
> C:/Perl64/lib/CORE/embedvar.h:62:19: note: in expansion of macro 'vTHX'
>   #define PL_Mem   (vTHX->IMem)
>                     ^~~~
> C:/Perl64/lib/CORE/iperlsys.h:813:4: note: in expansion of macro 'PL_Mem'
>    (*PL_Mem->pMalloc)(PL_Mem, (size))
>      ^~~~~~
> C:/Perl64/lib/CORE/XSUB.h:628:21: note: in expansion of macro 
> 'PerlMem_malloc'
>   #    define malloc  PerlMem_malloc
>                       ^~~~~~~~~~~~~~
> C:/prg/gnu/texinfo/svn/tp/Texinfo/MiscXS/misc.c:468:9: note: in 
> expansion of macro 'malloc'
>     new = malloc (new_space + 1);
>           ^
> 
> 
> Oh, and BTW: 'info.exe' fails to build because some of the dummy 
> functions in pcterm.c::1685 ff. have the wrong prototypes:
> 
> In file included from C:/prg/gnu/texinfo/svn/info/terminal.c:1299:0:
> C:/prg/gnu/texinfo/svn/info/pcterm.c:1685:11: error: conflicting types 
> for 'tputs'
>   int       tputs (const char *a, int b, int (*c)(int))
>             ^~~~~
> In file included from C:/prg/gnu/texinfo/svn/info/terminal.c:40:0:
> C:/msys64/mingw64/include/termcap.h:31:13: note: previous declaration of 
> 'tputs' was here
>   extern void tputs (const char *string, int nlines, int (*outfun) (int));
>               ^~~~~

I've just committed a few changes that should solve these for you.
Please test.

I actually came to the conclusion that Gnulib's overriding of the
wint_t type is a bad idea.  I'm going to post to Gnulib mailing list;
if you agree, please back me up there.

Thanks.