[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: info segfaults when using tree-search-next
From: |
Gavin Smith |
Subject: |
Re: info segfaults when using tree-search-next |
Date: |
Wed, 24 May 2017 19:03:08 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, May 24, 2017 at 10:31:54AM +0200, Benno Schulenberg wrote:
>
> On Wed, May 24, 2017, at 08:58, Gavin Smith wrote:
> > On Sun, May 21, 2017 at 06:17:57PM +0200, Benno Schulenberg wrote:
> > > To reproduce, run 'info/ginfo doc/info-stnd.info node'.
> > > Then type: Alt+/ wed <Enter>.
> > > Then type five times Alt+Shift+}.
> > > Segmentation fault.
> >
> > Thanks for finding this; I've fixed it.
>
> Verified as fixed.
>
> But... when does the message "Going back to last match from %s"
> now occur? As far as I can tell, it always gets overwritten by
> "No more matches". So it seems the first one can be dropped.
I'm not sure why I added that message in the first place, but I
think was was because I was concerned about searching through
large files and showing the user what was happening, so the program
wouldn't appear to have crashed if it was taking a long time to go back
to the last match. The other searching commands do have messages
that can be printed while the searching is happening, like
"Searching subfile %s...", although they don't print messages like
"Going forward to next match...". I don't know whether this message
is really necessary, but it seems harmless to include it.