Re: [GSoC] Javascript for info-style navigation

[Mathieu Lirzin]

Hello,

Assaf Gordon <address@hidden> writes:

> few comments:
>
> 1.
> On older browsers (e.g. Safari 8), the javascript fails to load with:
> ==
>  [Error] TypeError: undefined is not a function (evaluating 
> 'window.location.pathname.endsWith (config.INDEX_NAME)')
>    (anonymous function) (kawa-ebook.js, line 2032)
>    global code (kawa-ebook.js, line 2062)
> ==

I have added a polyfill for 'String.prototype.endsWith' in the
repository.

> 2.
> The left-side menu isn't scrolled to the active item
> when it is a very low item (at the bottom).
> Example (in Chrome 59):
>
> 2.1. Load this page:
>     http://www.gnu.org/software/texinfo/gsoc-2017-js-example/kawa/
> 2.2. Press "N" 4 times (you should be at "Getting and installing Kawa")
> 2.3. Press "[" (back) once:
>     you should see the "Optional strict typing along with an explicit
>     dynamic type" node,
>     but the left-side menu isn't scrolled down to show it.
> 2.4. Same happens if pressing '[' and ']' multiple times.

Noted.

> 3.
> Keyboard scrolling of the content pages isn't always working.
> Example (in Chrome 59):
> 3.1. Load this page:
>     http://www.gnu.org/software/texinfo/gsoc-2017-js-example/kawa/
> 3.2. Press "N" once (you should be at "News - Recent Changes" which is a long 
> page.)
>     now pressing "space" or "down arrow" does not scroll the page
>     (which kinds of defeat the entire keyboard navigation...)
> 3.3. If you click once (with the mouse) inside the content pane,
>     it does get the focus and from now on space/down arrow will work
>     in this node only.
> 3.4. Press ']' to move to the next node - keyboard navigation
>     doesn't work.
> 3.5. Press '[' to move back to the "News - Recent Changes" node) -
>     keyboard navigation works again
>     (If I had to guess - that node's element kept the focus).

Noted, I have been able to reproduce this with Chromium 59.  With
Firefox 54 the focus works fine.

> 4.
> There's some inconsistency in the menu navigation of the left-side bar.
> Example (in Chrome 59):
> 4.1. Load this page:
>     http://www.gnu.org/software/texinfo/gsoc-2017-js-example/kawa/
> 4.2. Press "N" three times (should be on "The Kawa Community" node)
> 4.3. Press "]" once (should be on "Reporting bugs" node)
> 4.4. Press "N" five times (should be on "Ideas and tasks for contributing to 
> Kawa" node)
> 4.5. Press "]" once (should be on "Run interactive process in separate JVM")
> 4.6. Based on the menu structure, I'd expect "N" to work and move
>     to the next item on the same level (at least as displayed
>     in the left-side menu). But it doesn't.
>     "P" and "U" also don't work.
>     Only "[" and "]" do.

Yes this is a known issue.  For every link in the sidebar that refers to
an anchor in a page the 'n', 'p', and 'u' are not handled.

> Hope this helps,

This is really helpful.  I have added TODO entries in the development
repository for the issues you have reported.

Thank you.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37