Re: [platform-testers] texinfo-6.5.90 pretest on Solaris 10

[Gavin Smith]

On 1/5/19, Bruno Haible <address@hidden> wrote:
> On a Solaris 10 machine (with GNU libiconv installed), the build
> fails:
>
> "../../../../../tp/Texinfo/XS/parsetexi/input.c", line 113: warning: no
> explicit type given
> "../../../../../tp/Texinfo/XS/parsetexi/input.c", line 113: syntax error
> before or at: iconv_from_latin1
>
> Looks like the 'iconv_t' type is not defined.
>
> The gnulib module 'iconv' ought to resolve all issues around iconv().
>
> Logs attached.

Thanks for testing. In spite of the comment in the code, the 'iconv'
gnulib is already supposed to be in use.

I am not sure that gnulib actually does take care of missing iconv_t -
it's not mentioned in the gnulib manual. I don't think gnulib is
providing an iconv implementation.

I looked through the gnulib ChangeLog to see if there had been any
recent changes and I discovered there is an "iconv-h" module, which is
not mentioned anywhere in the gnulib manual. Do you know if that is
the module we need?

I am not sure why iconv is not being found when configuring the XS
subdirectory. In the configure log "log1" that you sent, at the top
level there is:

checking for iconv... yes
checking for working iconv... yes
checking how to link with libiconv...
/home/haible/prefix-x86_64/lib/libiconv.so
-R/home/haible/prefix-x86_64/lib

but under the XS subdirectory, it is:

checking for iconv... no, consider installing GNU libiconv

This could be explained by a different compiler and flags being used
to build a Perl XS module. But it is "cc" being used in both cases.
For some reason this works with the iconv_t type (using the top-level
configuration):

source='../../info/info-utils.c' object='info-utils.o' libtool=no \
DEPDIR=.deps depmode=none /bin/bash ../../build-aux/depcomp \
cc -xarch=generic64 -O -D_STDC_C99= -DHAVE_CONFIG_H -I. -I../../info
-I..  -I../..                                -I../../gnulib/lib
             -I../gnulib/lib
-DLOCALEDIR=\"/home/haible/prefix-x86_64/share/locale\"
-DINFODIR=\"/home/haible/prefix-x86_64/share/info\"
   -DINFODIR2=\"/home/haible/prefix-x86_64/share/info\"
-I/home/haible/prefix-x86_64/include -D_REENTRANT  -g -c -o
info-utils.o ../../info/info-utils.c

but this doesn't:

source='input.c' object='Parsetexi_la-input.lo' libtool=yes \
DEPDIR=.deps depmode=none /bin/bash ../../../../../tp/Texinfo/XS/depcomp \
/bin/bash ../libtool  --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I.
-I../../../../../tp/Texinfo/XS/parsetexi -I..
-I../../../../../tp/Texinfo/XS
-I../../../../../tp/Texinfo/XS/gnulib/lib      -I../gnulib/lib
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_TS_ERRNO -DVERSION=\"0\"
 "-I/usr/perl5/5.8.4/lib/i86pc-solaris-64int/CORE"  -c -o
Parsetexi_la-input.lo `test -f 'input.c' || echo
'../../../../../tp/Texinfo/XS/parsetexi/'`input.c


I don't know if it is the "-xarch=generic64" option that makes a
difference or something else.