bug-texinfo
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [platform-testers] texinfo-6.5.90 pretest on HP-UX


From: Bruno Haible
Subject: Re: [platform-testers] texinfo-6.5.90 pretest on HP-UX
Date: Sun, 20 Jan 2019 13:40:51 +0100
User-agent: KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; )

Hi Gavin,

> > + findprog zdiff
> > + zdiff ../../../install-info/tests/ii-0041-expected-dir-file.gz 
> > /tmp/haible015772.gz
> > Warning : missing newline at end of file 
> > ../../../install-info/tests/ii-0041-expected-dir-file.gz
> > Warning : missing newline at end of file /tmp/haible015772.gz
> > 1c1
> > <`�oG
> > ---
> > > �
> > + retval=1
> 
> Indeed, I looked at a hex dump of ii-0041-expected-dir-file.gz and "oG" 
> is near the start of the file.  It's not comparing the uncompressed 
> files properly.  Maybe the HP-UX zdiff doesn't support gzip format.
> ...
> * Bundle zdiff with texinfo
> * Avoid using zdiff and replicate its functionality in the test scripts using
>   more standard tools.
> * Check whether zdiff works as expected and skip the test if it doesn't.  This
>   would be easier than the previous two options.
> 
> Does the default zdiff with HPUX have a --version output that we could check?

$ zdiff --version
Usage: zdiff [diff_options] file [file]

I prefer the "avoid using zdiff" approach, because I find it better to
execute a test when possible rather than to skip it.

Patch attached. With it, all tests in this directory pass.

Bruno

Attachment: 0001-Fix-test-failures-on-HP-UX.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]