bug-texinfo
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: texinfo-6.6.90 pretest


From: Eli Zaretskii
Subject: Re: texinfo-6.6.90 pretest
Date: Mon, 19 Aug 2019 18:19:31 +0300

> From: Gavin Smith <address@hidden>
> Date: Sun, 18 Aug 2019 23:47:16 +0100
> 
> The first pretest for the next Texinfo release has been uploaded to
> 
> https://alpha.gnu.org/gnu/texinfo/texinfo-6.6.90.tar.xz

I've built this with MinGW on MS-Windows.  Two problems, now corrected
in Git, stopped the compilation: one in info/pcterm.c, the other in
tp/Texinfo/XS/parsetexi/api.c.

One other issue is that GCC 8 flags many uses of strncat in
install-info.c as unsafe:

     install-info.c: In function 'split_entry':
     install-info.c:1624:17: warning: 'strncat' specified bound 2 equals source 
length [-Wstringop-overflow=]
                      strncat (*description, "  ", 2);
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     install-info.c:1626:17: warning: 'strncat' specified bound 1 equals source 
length [-Wstringop-overflow=]
                      strncat (*description, " ", 1);
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     install-info.c:1639:3: warning: 'strncat' specified bound 1 equals source 
length [-Wstringop-overflow=]
        strncat (*description, "\n", 1);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     install-info.c: In function 'format_entry':
     install-info.c:1437:11: warning: 'strncat' specified bound 1 equals source 
length [-Wstringop-overflow=]
                strncat (outstr, "\n", 1);
                ^~~~~~~~~~~~~~~~~~~~~~~~~
     install-info.c:1442:15: warning: 'strncat' specified bound 1 equals source 
length [-Wstringop-overflow=]
                    strncat (outstr, " ", 1);
                    ^~~~~~~~~~~~~~~~~~~~~~~~
     install-info.c:1452:9: warning: 'strncat' specified bound 1 equals source 
length [-Wstringop-overflow=]
              strncat (outstr, " ", 1);
              ^~~~~~~~~~~~~~~~~~~~~~~~
     install-info.c:1508:15: warning: 'strncat' specified bound 1 equals source 
length [-Wstringop-overflow=]
                    strncat (outstr, "\n", 1);
                    ^~~~~~~~~~~~~~~~~~~~~~~~~
     install-info.c:1512:19: warning: 'strncat' specified bound 1 equals source 
length [-Wstringop-overflow=]
                        strncat (outstr, " ", 1);
                        ^~~~~~~~~~~~~~~~~~~~~~~~
     install-info.c:1541:5: warning: 'strncat' specified bound 1 equals source 
length [-Wstringop-overflow=]
          strncat (outstr, "\n", 1);
          ^~~~~~~~~~~~~~~~~~~~~~~~~
     install-info.c: In function 'split_entry.constprop':
     install-info.c:1634:11: warning: 'strncat' specified bound depends on the 
length of the source argument [-Wstringop-overflow=]
                strncat (*description, ptr, length);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     install-info.c:1633:27: note: length computed here
                size_t length = strlen (ptr);
                                ^~~~~~~~~~~~

This code hasn't changed in many years, FWIW.

Once the first 2 problems were fixed, the package built and passed all
the tests.

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]