bug-texinfo
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Texinfo 6.7 released


From: Eli Zaretskii
Subject: Re: Texinfo 6.7 released
Date: Fri, 27 Sep 2019 16:26:28 +0300

> Date: Fri, 27 Sep 2019 15:08:23 +0300
> From: Eli Zaretskii <address@hidden>
> Cc: address@hidden
> 
>   Free to wrong pool 3f5d48 not 40f015b at ..\tp/Texinfo/XSLoader.pm line 
> 224, <$fh> line 8.

FWIW, that line 224 of XSLoader.pm is the only line where there has
been a code change since Texinfo 6.6, see below.

Could it be that this change causes a string allocated by Perl to be
freed by a call to 'free' in the extension DLL?  On Windows, we must
not do that, as Perl could have been built with a different version of
malloc.

--- ../texinfo-6.6/tp/Texinfo/XSLoader.pm       2019-02-16 19:11:56.000000000 
+0200
+++ ./tp/Texinfo/XSLoader.pm    2019-09-23 21:31:55.000000000 +0300
@@ -1,4 +1,4 @@
-# Copyright 2014, 2015, 2016, 2017, 2018 Free Software Foundation, Inc.
+# Copyright 2014-2019 Free Software Foundation, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -23,7 +23,7 @@
 
 our $TEXINFO_XS;
 
-our $VERSION = '6.6';
+our $VERSION = '6.7';
 
 our $disable_XS;
 
@@ -221,7 +221,9 @@
   # This makes it easier to refer to packages and symbols by name.
   no strict 'refs';
   
-  if (defined &{"${module}::init"} and !&{"${module}::init"} ()) {
+  if (defined &{"${module}::init"}
+      and !&{"${module}::init"} ($Texinfo::ModulePath::texinfo_uninstalled,
+                                 $Texinfo::ModulePath::builddir)) {
     _fatal "$module_name: error initializing";
     goto FALLBACK;
   }



reply via email to

[Prev in Thread] Current Thread [Next in Thread]