Re: many tests with XS failing?

[Gavin Smith]

On Sun, Oct 25, 2020 at 12:39:04AM +0200, Patrice Dumas wrote:
> Hello,
> 
> It is a bit strange if it only happens to me so it could be something
> with my setup.  A lot of tests in t/ fail right now, and all the tests
> in tests, when using XS.
> 
> Errors are like
> ignore_and_comments.texi:4: warning: @c should only appear at the beginning 
> of a line
> and also some undefined values
> Use of uninitialized value $name in substitution (s///) at 
> ../../tp/Texinfo/Report.pm line 378
> 
> Everything is as expected with the pure perl parser.

It may be fixed in commit aa52e20a.  Due to a change in the enum type,
offsets into the array in command_data.c may have been wrong.

> When compiling the XS modules, there are some warnings, I attach the
> stderr from make in XS.
> 
> -- 
> Pat

> parsetexi/api.c: In function ‘element_to_perl_hash’:
> parsetexi/api.c:429:27: warning: cast from pointer to integer of different 
> size [-Wpointer-to-int-cast]
>   429 |               int value = (int) f;
>       |                           ^

There's not much chance of an overflow here but to avoid the warnings,
another integer type could be used instead.

> parsetexi/input.c:16: warning: "_GNU_SOURCE" redefined
>    16 | #define _GNU_SOURCE
>       | 
> <command-line>: note: this is the location of the previous definition
> parsetexi/macro.c:16: warning: "_GNU_SOURCE" redefined
>    16 | #define _GNU_SOURCE
>       | 

Need to check how to define this.