Re: texinfo-6.7.90 pretest on Solaris

[Gavin Smith]

On Sat, Feb 27, 2021 at 12:22:33PM +0100, Bruno Haible wrote:
> > https://alpha.gnu.org/gnu/texinfo/texinfo-6.7.90.tar.xz
> 
> A VPATH build on Solaris 10, with Solaris 'make', fails during "make check":
> 
> Making check in texindex
> make  check-TESTS
> FAIL: tests/ti-helpversion.sh
> 
> Why is that? Because the 'texindex' script is not executable.
> 
> How come that the 'texindex' script is not executable? The Makefile has
> built the 'texindex' script like this:
> 
> Making all in texindex
> sed -e 's,[@]pkgdatadir[@],/home/haible/prefix-sparc64/share/texinfo,g'  -e 
> 's,[@]TI_AWK[@],awk,g'  -e 's,[@]PACKAGE[@],texinfo,g'  -e 
> 's,[@][@]*VERSION[@][@]*,6.7.90,g' <../../texindex/texindex.in >texindex
> chmod +x ../../texindex/texindex

I don't understand how that is possible as
"chmod +x texindex" is hard-coded in the Makefile.

> As you can see, it has added the execution permission to 'texindex'
> in the source dir, not to 'texindex' in the build dir.
> 
> If I remove the 'texindex' in the source dir, then the Makefile rule
> executes as expected:
> 
> Making all in texindex
> sed -e 's,[@]pkgdatadir[@],/home/haible/prefix-sparc64/share/texinfo,g'  -e 
> 's,[@]TI_AWK[@],awk,g'  -e 's,[@]PACKAGE[@],texinfo,g'  -e 
> 's,[@][@]*VERSION[@][@]*,6.7.90,g' <../../texindex/texindex.in >texindex
> chmod +x texindex
> 
> So, the cause is that an autogenerated and platform-dependent 'texindex'
> script was included in the tarball. Removing it from the tarball will fix
> the issue.

I've attempted to fix the issue.  Thanks for the report.  It was wrong
for the file ever to be included in the distribution.